• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Walkthrough

EPICS CA IOC now skips Waveform attributes with dimensionality >1 (logs a warning) and computes PV names only after this check. Some print statements were replaced with logger.warning. A unit test was added to assert only 1D Waveforms produce PV creation calls.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I nibble shapes both big and small,
1D stays cozy, the rest I stall.
A gentle warning, soft and clear,
I skip the grids that won't appear.
Hooray — the PVs now know who to call.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

src/fastcs/transports/epics/ca/ioc.py (2)

135-143: Set attribute.enabled = False for consistency with other skip paths.

The condition is now correct (!= 1), but skipped waveform attributes aren't marked disabled unlike other skip paths in this function (lines 148 and 164 both set attribute.enabled = False). This inconsistency could cause issues if downstream code relies on enabled to determine which attributes were successfully exposed.

♻️ Proposed fix

             if (
                 isinstance(attribute.datatype, Waveform)
                 and len(attribute.datatype.shape) != 1
             ):
                 logger.warning(
                     "Only 1D Waveform attributes are supported in EPICS CA transport",
                     attribute=attribute,
                 )
+                attribute.enabled = False
                 continue

---

260-263: Remaining print statement should use logger.warning for consistency.

This warning message uses print while the equivalent warnings in _create_and_link_attribute_pvs (lines 149, 159) now use logger.warning. Consider updating for consistent logging.

♻️ Proposed fix

             if len(f"{pv_prefix}:{pv_name}") > EPICS_MAX_NAME_LENGTH:
-                print(
+                logger.warning(
                     f"Not creating PV for {attr_name} as full name would exceed"
                     f" {EPICS_MAX_NAME_LENGTH} characters"
                 )
                 method.enabled = False